Patrick Steinhardt <ps@xxxxxx> writes: > In a subsequent commit we'll add another user that wants to write reflog > entries. This requires them to call `ref_transaction_update_reflog()`, > but that functino is local to "refs.c". > > Export the function to prepare for the change. While at it, drop the > `flags` field, as all callers are for now expected to use the same flags > anyway. > > Signed-off-by: Patrick Steinhardt <ps@xxxxxx> > --- > refs.c | 29 +++++++++++------------------ > refs.h | 15 +++++++++++++++ > 2 files changed, 26 insertions(+), 18 deletions(-) > > diff --git a/refs.c b/refs.c > index 73913b6627b..188989e4113 100644 > --- a/refs.c > +++ b/refs.c > @@ -1362,27 +1362,21 @@ int ref_transaction_update(struct ref_transaction *transaction, > return 0; > } > > -/* > - * Similar to`ref_transaction_update`, but this function is only for adding > - * a reflog update. Supports providing custom committer information. The index > - * field can be utiltized to order updates as desired. When not used, the > - * updates default to being ordered by refname. "not used" is a little ambiguous for me. I had to dig a little and in transaction_update_cmp() in refs/reftable-backend.c the index is only considered when the value is non-zero. What do you think about replacing "not used" with "zero"? -- Cheers, Toon
