Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: > On Tue, Jul 22, 2025 at 8:11 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: >> * hl/test-helper-fd-close (2025-07-22) 2 commits >> - t/helper/test-delta: fix possible resource leak and ensure safe cleanup >> - t/helper/test-truncate: close file descriptor after truncation >> >> A few file descriptors left unclosed upon program completion in a >> few test helper programs are now closed. >> >> Comments? >> source: <20250722174102.1876197-1-lhywkd22@xxxxxxxxx> > > I left comments[*] on patch [2/2]. Although the intention of the > change seems reasonable (patching holes in the existing "cleanup" of > `fd`), I have concerns that the commit message is misleading, and > (more importantly) that the patch itself is flawed. As such, I think a > reroll is warranted. > > [*]: https://lore.kernel.org/git/CAPig+cR-r=CeEaSTeWsX00MLCSRJUUVXMUWS6Ui-HQcR_qMGJA@xxxxxxxxxxxxxx/ Thanks.
