Re: [GSoC][RFC PATCH v2 1/2] builtin/refs: add list subcommand

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 17 Jul 2025 at 22:18, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote:
>
> On Thu, Jul 17, 2025 at 3:50 AM Meet Soni <meetsoni3017@xxxxxxxxx> wrote:
[snip]

> > diff --git a/Documentation/refs-list-options.adoc b/Documentation/refs-list-options.adoc
> > @@ -0,0 +1,80 @@
> > +// Shared options for for-each-ref and refs list
> > +<pattern>...::
> > +       If one or more patterns are given, only refs are shown that
> > +       match against at least one pattern, either using fnmatch(3) or
> > +       literally, in the latter case matching completely or from the
> > +       beginning up to a slash.
>
> Nit: We probably don't want the "// Shared options for..." comment. If
> someone needs to know which commands share this documentation, a
> suitable "grep" invocation will provide the same information but will
> be correct at that point in time, whereas a comment like this one can
> become stale over time.


Makes sense, I'll remove it in the next version.

Apologies for the delayed response, I was away last week.
Thanks





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux