Changes since v2:
- Dropped the second patch (`builtin/archive.c`) as discussed.
- Combined both resource leak fixes in `t/helper/test-delta.c` into a
single patch using a unified cleanup path via `goto`.
- Ensured file descriptor is safely initialized and closed only when needed.
Thanks for the detailed and thoughtful reviews. Your comments helped me better understand how resource cleanup should be handled, especially when dealing with early program termination.
I especially appreciate your in-depth explanation regarding the difference between true resource leaks and stack-unwinding cases. The example you gave was very insightful, and it clarified how automated tools and reviewers should assess whether a resource is truly leaked. Thank you for taking the time to provide such a clear and instructive explanation.
Hoyoung Lee (2):
t/helper/test-truncate: close file descriptor after truncation
t/helper/test-delta: fix possible resource leak and ensure safe
cleanup
t/helper/test-delta.c | 9 +++++----
t/helper/test-truncate.c | 3 +++
2 files changed, 8 insertions(+), 4 deletions(-)
--
2.34.1
