On Thu, Jul 17, 2025 at 08:02:37PM -0400, Taylor Blau wrote: > > + /* > > + * Is it arriving at a version of interest, or is it from a side branch > > + * which did not contribute to the final state? > > + */ > > + if (!oideq(oid, &ent->oid)) > > + return; > > GitHub's fork writes this as "if (oid && !oideq(oid, &ent->oid))", but > the commit that introduces the "oid &&" portion of that expression > doesn't provide us with any clues as to why the change was necessary. > > Since you have spent more time with these patches than I have recently, > perhaps you can help shed some light on what's going on here? In the version from tb/blame-tree of your repo, the caching system calls mark_path() with a NULL oid. But none of that code is in Toon's version here. The only call to mark_path() in this series always passes a pointer to a real struct. -Peff
