On Fri, Jul 18, 2025 at 8:38 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > "Ezekiel Newren via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > > > This series accelerates xdiff by 5-19%. > > ;-) > > Do we know how much of that can be attributed to the hash algorithm > difference, and how much for languages? This is difficult to answer because xdl_hash_record() hashes the string as it determines its length. Xxhash uses simd instructions, so all data must be contiguous and processed as blocks rather than byte by byte. The components cannot be directly compared due to the nature of processing differences. > The earlier parts of the series to trim unused code and refactor > look to me that they are good changes regardless of whether we > introduce a different hash algorithm, and/or we use an > implementation of that different hash algorithm written in Rust. > IOW, even if neither of these two happens, I would think that the > earlier parts are independently good pieces. > > Thanks for starting this effort. And thanks Elijah for helping. > > And in case nobody has said this yet, welcome to the Git development > community. Thanks to you and everyone else for your review comments. I'm going to need time to investigate and respond.
