On Wed, Jul 16, 2025 at 02:07:54PM -0700, Junio C Hamano wrote:
> eab5dbab (ci: wire up Meson builds, 2024-12-13) added two instances
> of a very similar construct
>
> FAILED_TEST_ARTIFACTS=${TEST_OUTPUT_DIRECTORY:-t}/failed-test-artifacts
>
> one to ci/lib.sh and the other to ci/print-test-failures.sh
> Unfortunately, the latter had a typo causing shell to emit "Bad
> substitution". Fix it.
>
> Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
> ---
> ci/print-test-failures.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ci/print-test-failures.sh b/ci/print-test-failures.sh
> index dc910e5160..5545e77c13 100755
> --- a/ci/print-test-failures.sh
> +++ b/ci/print-test-failures.sh
> @@ -41,7 +41,7 @@ do
> case "$CI_TYPE" in
> github-actions)
> mkdir -p failed-test-artifacts
> - echo "FAILED_TEST_ARTIFACTS=${TEST_OUTPUT_DIRECTORY:t}/failed-test-artifacts" >>$GITHUB_ENV
> + echo "FAILED_TEST_ARTIFACTS=${TEST_OUTPUT_DIRECTORY:-t}/failed-test-artifacts" >>$GITHUB_ENV
> cp "${TEST_EXIT%.exit}.out" failed-test-artifacts/
> tar czf failed-test-artifacts/"$test_name".trash.tar.gz "$trash_dir"
> continue
Oh, indeed. Thanks for catching the mistake, the patch looks obviously
good to me.
Patrick
