Re: [PATCH v5] meson: work around broken system PCRE2 dependency in macOS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 16, 2025 at 3:10 PM Eli Schwartz <eschwartz@xxxxxxxxxx> wrote:
>
> On 7/16/25 3:30 PM, Carlo Marcelo Arenas Belón wrote:
>
> > +if pcre2.found() and pcre2.type_name() != 'internal' and host_machine.system() == 'darwin'
> > +  # macOS installs a broken system package, double check
> > +  if not compiler.has_header('pcre2.h', dependencies: pcre2)
> > +    if pcre2_feature.enabled()
> > +      # Attempt to fallback, method can't be pkg-config
> > +      pcre2 = dependency('libpcre2-8', method: 'builtin', default_options: ['default_library=static', 'test=false'])
> > +      if not pcre2.found()
> > +        error('only a broken pcre2 install found and pcre2 is required')
>
> If you want to override the message from a specific dependency() call,
> "required" defaults to true and aborts on the line before
> "if not pcre2.found()"

It is a little hacky, but because we are not using the method: auto, then won't
try pkg-config again and fallback to the wrap because as you said, required
defaults to true, and allow_fallback is true if required is true.

The only way this dependency() will fail is if --wrap-mode=nofallback and that
won't cause it to abort.

Carlo





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux