Ayush Chandekar <ayu.chandekar@xxxxxxxxx> writes: > On Wed, Jul 16, 2025 at 2:53 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: >> > [snip] >> >> This patch is exactly what Phillip suggested in >> >> https://lore.kernel.org/git/9e96aaab-79a2-4632-94cd-d016d4a63b30@xxxxxxxxx/ >> >> isn't it? Makes sense to me. >> > > Yes, you're right. I should add the suggested-by trailer for this patch. I am not sure about that, though. A verbatim copy is stronger than implementing what was suggested by another person. If I were in your position, I'll probably say something like The patch text was taken from Phillip Wood's message [*URL*], with the commit log message written by me. Based-on-a-patch-by: Phillip Wood <...> Signed-off-by: Ayush Chandekar <...> In any case, this overlaps both textually but also intent-wise with Phillip's "let's mark core.commentchar=auto deprecated and remove the support at 3.0 boundary", which is planned to be rerolled to make it a failure when the user uses core.commentchar=auto. It would be a while before we tag Git 3.0, so the fix in this topic will be necessary until then. Thanks.
