Elijah Newren <newren@xxxxxxxxx> writes:
>> Since 8277dbe987 (git-compat-util: convert skip_{prefix,suffix}{,_mem}
>> - to bool, 2023-12-16) a number of our sting predicates have been
>> - returning bool instead of int. Now we've declared that experiment
>> - a success lets convert the return type the case independent
>> + to bool, 2023-12-16) a number of our string predicates have been
>> + returning bool instead of int. Now that we've declared that experiment
>> + a success, let's convert the return type of the case-independent
>> skip_iprefix() and skip_iprefix_mem() functions to match the return
>> - type of their case dependent equivalents. Returning bool instead of
>> + type of their case-dependent equivalents. Returning bool instead of
>> int makes it clear that these functions are predicates.
>>
>> Signed-off-by: Phillip Wood <phillip.wood@xxxxxxxxxxxxx>
>> 3: 7eaf8042061 = 3: 66968714739 strbuf: convert predicates to return bool
>> --
>> 2.49.0.897.gfad3eb7d210
>
> This version looks good to me, thanks!
Thanks, looking good.
