Toon Claes <toon@xxxxxxxxx> writes: > Patrick Steinhardt <ps@xxxxxx> writes: > >> The summary of auto-detected features prints a boolean for every option >> to tell the user whether or not the feature has been auto-enabled or >> not. This summary can be improved though, as in some cases this boolean >> is derived from a dependency. So if we pass in the dependency directly, >> then Meson knows to both print a boolean and, if the dependency was >> found, it also prints a version number. >> >> Adapt the code accordingly and enable `bool_yn` so that actual booleans >> are formatted similarly to dependencies. Before this change: >> >> Auto-detected features >> benchmarks : true >> curl : true >> expat : true >> gettext : true >> gitweb : true >> iconv : true >> pcre2 : true >> perl : true >> python : true >> >> And after this change, we now see the version numbers as expected: >> >> Auto-detected features >> benchmarks : YES >> curl : YES 8.14.1 >> expat : YES 2.7.1 >> gettext : YES >> gitweb : YES >> iconv : YES >> pcre2 : YES 10.44 >> perl : YES >> python : YES >> >> Note that this change also enables colorization of the boolean options, >> green for "YES" and red for "NO". > > Nice, I'm really liking this change. > > I've also reviewed the rest of the patches, and all looks good to me. Thanks.
