"D. Ben Knoble" <ben.knoble@xxxxxxxxx> writes: >> +test_expect_success 'submodule add skips redundant active entry' ' >> + git init repo && >> + ( >> + cd repo && >> + git config submodule.active "lib/*" && >> + git commit --allow-empty -m init && >> + >> + git init ../lib-origin && >> + git -C ../lib-origin commit --allow-empty -m init && >> + >> + git submodule add ../lib-origin lib/foo && >> + ! git config --get submodule.lib/foo.active > > (Not my area of expertise) Should this be test_must_fail? That is certainly better. "! git config ..." would succeed even when that command segfaults and dumps core, which we may want to notice.
