Re: [PATCH v4 0/3] fetch --prune performance problem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 07, 2025 at 03:43:12PM -0700, Junio C Hamano wrote:

> Phil Hord <phil.hord@xxxxxxxxx> writes:
> 
> > From: Phil Hord <phil.hord@xxxxxxxxx>
> >
> > `git fetch --prune` runs in O(N^2) time normally. This happens because the code
> > iterates over each ref to be pruned to display its status. In a repo with
> > 174,000 refs, where I was pruning 15,000 refs, the current code made 2.6 billion
> > calls to strcmp and consumed 470 seconds of CPU. After this change, the same
> > operation completes in under 1 second.
> > ...
> > V3 forgot to include the first commit in the series (I forgot it grew).
> > So here's V4.
> >
> > Phil Hord (3):
> >   fetch-prune: optimize dangling-ref reporting
> >   refs: remove old refs_warn_dangling_symref
> >   clean up interface for refs_warn_dangling_symrefs
> 
> It seems that the thread has gone quiet.  What's the status of this
> topic?

v4 looks fine to me. I raised a few questions about the translation
strings, but I don't know if they're meaningful or not.

-Peff




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux