Re: [PATCH] pretty: add X-Change-ID to mail formats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sweet! I'm going to send a follow-up with git-am support.

On Thu Jul 3, 2025 at 10:41 AM CEST, Remo Senekowitsch wrote:
> This can kind of be tested already. Because Jujutsu already writes the
> change-id header and sends it via git push, it must also be able to
> import those headers from commits it hasn't seen before. Possible steps
> to verify this behavior:
>
> * Create a repo with Jujutsu, make some commits, push them to a remote.
>   (can be one on the local file system)
>
> * Clone this repo via Git.
>
> * (optional) Confirm with `git cat-file -p @` that the change-id header
>   was preserved.
>
> * Run `jj git init --colocate .` to upgrade the git repo to a jj repo.
>
> * Run `jj log` and observe that Jujutsu correctly imported the change-id
>   headers of existing commits it didn't know about previously.

I can confirm all of this works with the v2 I'm about to send, though I
have ascertained as much through a manual testing procedure that
resembles your recommendation here.

One thing I'm less certain about is how to expand the tests in t/ to
test this behavior. I'll elaborate in the timely commentary of v2.

Attachment: 42F3F1862E3CC4B8.asc
Description: application/pgp-keys

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux