Phillip Wood <phillip.wood123@xxxxxxxxx> writes: > On 01/07/2025 16:54, Junio C Hamano wrote: >> Phillip Wood <phillip.wood123@xxxxxxxxx> writes: >> >>>> * add OPT_DIFF_*() macros to parse-options API, as its utility is >>>> very narrow, and forces those who are learning parse-options API >>>> to learn one more thing. >>> >>> It means that we have consistent help for all the commands with these >>> options which I think is valuable. We have a number of other macros >>> that define options that are shared between commands and I think that >>> works quite well. >> I understand that principe. What I was wondering was if there are >> enough places to use these particular ones to make it worthwhile to >> enlarge the set of OPT_* macros. > > There are six users of each of these macros so I think it is > worthwhile. That's two more users than there are for > OPT_RERERE_AUTOUPDATE() and twice as many users as OPT_CONTAINS(). OK. Thanks.
