On 25/07/01 02:22PM, Patrick Steinhardt wrote: > Hi, > > this patch series refactors the object store subsystem to become more > self-contained by getting rid of `the_repository`. Instead of passing in > the repository explicitly, we start to pass in the object store itself, > which is in contrast to many other refactorings we did, but in line with > what we did for the ref store, as well. > > This series also starts to properly scope functions to the carved out > object database subsystem, which requires a bit of shuffling. This > allows us to have a short-and-sweet `odb_` prefix for functions and > prepares us for a future with pluggable object backends. Nice to see the odb subsystem take shape and become more self-contained. > The series is structured as follows: > > - Patches 1 to 3 rename `struct object_store` and `struct > object_directory` as well as the code files. > > - Patches 4 to 12 refactor "odb.c" to get rid of `the_repository`. > > - Patches 13 to 17 adjust the name of remaining functions so that they > can be clearly attributed to the ODB. I'm happy to kick these > patches out of this series and resend them at a later point in case > they create too much turmoil. > > This series is built on top of 6f84262c44a (The eleventh batch, > 2025-05-05) with ps/object-store-cleanup at 8a9e27be821 (object-store: > drop `repo_has_object_file()`, 2025-04-29) merged into it. There are a > couple of trivial conflicts when merged with "seen", I have appended the > merge conflict resolution as a patch at the end of this mail. [snip] > Changes in v6: > - Fix a mis-merged comment. > - A couple of commit message improvements. > - Link to v5: https://lore.kernel.org/r/20250605-pks-object-store-wo-the-repository-v5-0-779d1c28774b@xxxxxx The changes in the range-diff are good. This version looks good to me. -Justin
