On 25/06/30 11:34AM, Junio C Hamano wrote: > "Raymond E. Pasco" <ray@xxxxxxxxxxxx> writes: > > > It makes no sense to register an intent to add outside a repository. We > > should error out here. > > I am not so sure, especially if you still keep the original "if we > are using 'git apply' as a better GNU patch, ignore -N" logic. > > Not that I am suggesting to also error out when -N is given without > --index or --cached, that is. > > I think the most problematic is the claim "it makes no sense" is not > linked to the conclusion "we should error out". The behaviour of > the original code, and the behaviour of the code with this patch in > "a better GNU patch" mode is based on "it makes no sense in such a > context, hence we just ignore (instead of erroring out)", which > makes perfect sense as well. Yeah, perhaps that's right. My thought was that "the user said -N, they must think they're in a repository". On the other hand, however, it's a lot weaker than saying --index or --cached, which mean the user definitely wants to manipulate a git repository; the user is still /mainly/ trying to manipulate files if they use -N.
