On Sat, Jun 28, 2025 at 12:56 PM shejialuo <shejialuo@xxxxxxxxx> wrote: > > On Sun, Jun 08, 2025 at 06:36:34AM +0530, Ayush Chandekar wrote: > > The 'extensions.preciousObjects' settings when set true, prevents > > Should "settings" be "setting"? > Yeah, thanks for correcting! > > operations that might drop objects from the object storage. > > This setting is populated in the global variable > > 'repository_format_precious_objects'. > > Move this global variable to repo scope by adding it to 'struct > > repository' and also refactor all the occurences accordingly. > > > > This change is part of an ongoing effort to eliminate global variables, > > improve modularity and help libify the codebase. > > > > Signed-off-by: Ayush Chandekar <ayu.chandekar@xxxxxxxxx> > > Maybe you should add the following things before "Signed-off-by": > > Mentored-by: ... > Mentored-by: ... > Oh, I missed it on this patch series, apologies, I'll update it. > Thanks, > Jialuo Thanks:)
