On Tue, Jun 24, 2025 at 08:37:30AM -0800, Junio C Hamano wrote: > "Carlo Marcelo Arenas Belón via GitGitGadget" > <gitgitgadget@xxxxxxxxx> writes: > > > From: =?UTF-8?q?Carlo=20Marcelo=20Arenas=20Bel=C3=B3n?= <carenas@xxxxxxxxx> > > > > In a future change, the flags used for processing SIGCHLD will need to > > be updated, which is only possible by using sigaction(). > > > > Replace the call, which hs the added benefit of using BSD semantics > > reliably and therefore not needing the rearming call. > > "hs" -> "has" > > Hmph, if we do not have to rearm, do we even need to have the > handler at all, now it is a completely empty function? Presumably > we'll see the answer to this question in the next step? I didn'r address it because I didn't knew where to put it, but removing the signal handler isn't possible, because as soon as we do, EINTR is no longer "returned" by `poll()` on the systems that allowed that as an exception to SA_RESTART rules, and even trying to force it with `siginterrupt()` no longer works, not even returning an error. Carlo
