I'm sending a new version of the diff driver. I tried to expand recognition of functions to more possible cases, improved tests in t4018 for function matching of the pattern and tried to add test t4034 for the matching of words. I added a lot more test for t4018, so much that I got caught up if I was exaggerating. I was not trying to exhaust all possibilities, I just think that javascript has a lot of different valid syntaxes for declaring functions and I was trying to make a somewhat complete coverage of that. Let me know if perhaps I'm going too far along this direction. I also tried to incorporate your feedbacks, thanks! > Thank you for your contribution. We have had a number of submissions for > Javascript or Typescript drivers in the past, but none of them were > followed through to be integrated. > Typescript: > https://lore.kernel.org/git/20240404163827.5855-1-utsavp0213@xxxxxxxxx/ > https://lore.kernel.org/git/pull.1746.git.git.1721061218993.gitgitgadget@xxxxxxxxx/ > Javascript: > https://lore.kernel.org/git/20240301074048.188835-1-sergiusnyah@xxxxxxxxx/ > https://lore.kernel.org/git/20220403132508.28196-1-a97410985new@xxxxxxxxx/ > Please review these submission and the responses that they received. > Perhaps you can find inspiration for improvement from them. It has beeing great fun :)! I took a deep dive into the suggested submissions. For clarity purposes, I'll be addressing them for the following index, and sometimes for the contributor's name: [1] Utsav Parmar: https://lore.kernel.org/git/20240404163827.5855-1-utsavp0213@xxxxxxxxx/ [2] Mattew Hughes: https://lore.kernel.org/git/pull.1746.git.git.1721061218993.gitgitgadget@xxxxxxxxx/ [3] Sergius Nyah: https://lore.kernel.org/git/20240301074048.188835-1-sergiusnyah@xxxxxxxxx/ [4] Xing Zhi Jiang: https://lore.kernel.org/git/20220403132508.28196-1-a97410985new@xxxxxxxxx/
