Re: [PATCH] imap-send: improve error messages for missing configuration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 20 June 2025 10:33:21 am IST, Aditya Garg <gargaditya08@xxxxxxxx> wrote:
>
>
>On 20 June 2025 6:28:32 am IST, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>>"Jörg Thalheim" <joerg@xxxxxxxxxxx> writes:
>>
>>> The error message 'no imap store specified' was confusing because
>>> it referred to 'store' when the actual missing configuration was
>>> 'imap.folder'. Similarly, the host error message provided no
>>> guidance on how to fix the issue.
>>>
>>> Improve both error messages to:
>>> - Clearly state what configuration is missing
>>> - Provide hints showing the exact git config commands needed
>>> - Include examples of typical values
>>>
>>> This helps users quickly understand and resolve configuration issues
>>> when using git imap-send.
>>>
>>> Signed-off-by: Jörg Thalheim <joerg@xxxxxxxxxxx>
>>> ---
>>>  imap-send.c | 8 ++++++--
>>>  1 file changed, 6 insertions(+), 2 deletions(-)
>>
>>It is curious that you are sending usability improvement patches to
>>imap-send, which I was recently told to be completely broken wrt the
>>use of imap.folder.  Is the claim I heard that it is totally broken
>>not true after all, I wonder?
>
>I assume either the person has used the seen branch, or has not tested the program itself.

Actually you get the error:

no imap store specified

In the broken imap send irrespective of what you do IIRC. Maybe that's what is being addressed here.





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux