Thanks for your feedback Patrick. I'm resending the patch with your
suggestions.
'test_path_is_file' and 'test_path_is_dir' are modern debbuging-friendly
path checking methods in Git's development that output useful messages
when the test fails, unlike 'test -f' and 'test -d' that don't provide
feedback.
Replace 'test -d' and 'test -f' methods with 'test_path_is_dir' and
'test_path_is_file'.
Signed-off-by: Derick W. de M. Frias <derick.william.moraes@xxxxxxxxx>
---
t/t0200-gettext-basic.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t0200-gettext-basic.sh b/t/t0200-gettext-basic.sh
index 8853d8afb9..89d0899a5b 100755
--- a/t/t0200-gettext-basic.sh
+++ b/t/t0200-gettext-basic.sh
@@ -31,12 +31,12 @@ test_expect_success 'xgettext sanity: Comment extraction with --add-comments sto
'
test_expect_success GETTEXT 'sanity: $TEXTDOMAINDIR exists without NO_GETTEXT=YesPlease' '
- test -d "$TEXTDOMAINDIR" &&
+ test_path_is_dir "$TEXTDOMAINDIR" &&
test "$TEXTDOMAINDIR" = "$GIT_TEXTDOMAINDIR"
'
test_expect_success GETTEXT 'sanity: Icelandic locale was compiled' '
- test -f "$TEXTDOMAINDIR/is/LC_MESSAGES/git.mo"
+ test_path_is_file "$TEXTDOMAINDIR/is/LC_MESSAGES/git.mo"
'
# TODO: When we have more locales, generalize this to test them
--
2.50.0.rc0.62.g658f0ae201.dirty
