Carlo Marcelo Arenas Belón <carenas@xxxxxxxxx> writes: > On Sun, Jun 15, 2025 at 11:08:27PM -0800, Rodrigo Michelassi wrote: >> From: rodrigocmichelassi <rodmichelassi@xxxxxxxxx> >> >> 'test_path_is_file', 'test_path_is_dir' and 'test_file_is_executable' are modern path checking methods in Git's development. Replace the basic shell commands 'test -f', 'test -d' and 'test -e', respectively, with this approach > > Splitting this long line, into multiple lines of about 70ish columns is > better, see the relevant documents in Documentation/ for useful suggestions. > >> Signed-off-by: Rodrigo Michelassi <rodmichelassi@xxxxxxxxx> > > This certifies that you are the author of the code, an therefore should go > after Isabella's, who might be the original author which you improved upon. > >> @@ -474,7 +474,7 @@ test_expect_success 'local clone --shared from linked checkout' ' >> >> test_expect_success '"add" worktree with --no-checkout' ' >> git worktree add --no-checkout -b swamp swamp && >> - ! test -e swamp/init.t && >> + ! test_path_is_executable swamp/init.t && > > this is not acurate translation, `test -e` is true if there is any "file" > with that name, the equivalent for that helper function would be `test -x` Yes, "test_path_is_missing" is what you want here, without any "!", to make sure that the path does not exist.
