Carlo Marcelo Arenas Belón <carenas@xxxxxxxxx> writes: > I was hoping something more like with the following (untested) "fixup" > on toa, obviously the "unconditionally" in the commit message should > need adding "for the supported versions" > > diff --git a/config.mak.uname b/config.mak.uname > index 9cac400d94..cbf1f4c0d2 100644 > --- a/config.mak.uname > +++ b/config.mak.uname > @@ -280,6 +280,9 @@ ifeq ($(uname_S),FreeBSD) > ifeq ($(firstword $(subst -, ,$(uname_R))),10.1) > OLD_ICONV = YesPlease > endif > + ifeq ($(shell test "`expr "$(uname_R)" : '\([1-9][0-9]*\)\.'`" -lt 12 && echo 1),1) > + NO_MEMMEM = UnfortunatelyYes > + endif > BASIC_CFLAGS += -I/usr/local/include > BASIC_LDFLAGS += -L/usr/local/lib > DIR_HAS_BSD_GROUP_SEMANTICS = YesPlease > > Note that either way the build won't be broken As I do not think we quite care about anything older than 12, I am perfectly fine being a bit extra defensive like your version. Care to assemble the final version with both code and log message updates? We are not in a hurry, as we are talking about a rather ancient issue and this will not come close to 'master' before the final release next week anyway. Thanks.
