Re: [PATCH v16 03/10] imap-send: gracefully fail if CRAM-MD5 authentication is requested without OpenSSL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On 10 Jun 2025, at 12:46 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> 
> Aditya Garg <gargaditya08@xxxxxxxx> writes:
> 
>> +                if (try_auth_method(srvc, ctx, imap, "CRAM-MD5", AUTH_CRAM_MD5, auth_cram_md5))
>>                    goto bail;
>> -                }
>>            } else {
>>                fprintf(stderr, "Unknown authentication method:%s\n", srvc->host);
>>                goto bail;
> 
> Outside the theme of this step (read: I am only leaving a mental
> note as potential #leftoverbits; I do not want to see this fixed as
> part of this step) and probably outside the theme of this series,
> but srvc->host is probably copy-and-paste-bug for srvc->auth_method
> I would think.

Good catch. I can make this minor change a part of v18.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux