commit d3d8c601fd ("t7815: fix unexpectedly passing test on macOS",
2025-06-02) added a MACOS prerequisite by adding a 'Darwin' case
label to the 'OS-specific' case statement. However, this commit
forgot to set several prerequisites which appear in the 'default'
case label, in addition to the new MACOS prerequisite. This causes
several tests, which macOS should pass, being skipped.
In order to run all applicable tests on macOS, add the missing
prerequisites to the 'Darwin' case.
Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx>
---
Hi Junio, Patrick,
I was looking at something else when I noticed this ... but I can't test
this, since I don't have access to a macOS system (indeed I can't confirm
that is actually a problem, but lots of tests should be being skipped! ;) ).
I initially deleted the 'Darwin' case and set the MACOS prerequisite after
the case statement - which may be a better solution. dunno.
I marked this RFC because I can't test this. Hint, Hint ...
Note, commit d3d8c601fd is only in next. If this is not going to be
part of the release, then this (or something similar) could be squashed
into it when the next branch is re-wound.
Thanks.
ATB,
Ramsay Jones
t/test-lib.sh | 3 +++
1 file changed, 3 insertions(+)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 9ffcae0472..51370a201c 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -1647,6 +1647,9 @@ uname_s=$(uname -s)
case $uname_s in
Darwin)
test_set_prereq MACOS
+ test_set_prereq POSIXPERM
+ test_set_prereq BSLASHPSPEC
+ test_set_prereq EXECKEEPSPID
;;
*MINGW*)
# Windows has its own (incompatible) sort and find
--
2.49.0
