Re: [PATCH v2 0/2] stash: fix and improve "git stash -p <pathspec>"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 4 Jun 2025 at 00:11, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> > Phillip Wood (2):
> >   stash: allow "git stash -p <pathspec>" to assume push again
> >   stash: allow "git stash [<options>] --patch <pathspec>" to assume push
>
> Are other people interested in this work?  I haven't seen any
> comments other than a few nitpicky one form mine, and want to (1)
> gauge the interest in the fix, and (2) see how well reviewed it is
> (and my review or reading over the patches again would not count all
> that much here).

On reading the patches, I realized that I have some interest in this. I
left some comments. Most of them amount to thinking out loud, but I do
think that the new test could do a bit better at proving that the
(fixed/improved) implementation actually ends up picking up `-p` at all.

A nice, pleasant read. The series has a well-defined focus.

Martin




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux