2025年6月6日 09:28，Junio C Hamano <gitster@xxxxxxxxx> 写道： > > "Lidong Yan via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > >> From: Lidong Yan <502024330056@xxxxxxxxxxxxxxxx> >> >> In pack-bitmap.c:find_boundary_objects(), the roots_bitmap is only freed >> if cascade_pseudo_merges_1() fails. Since cascade_pseudo_merges_1() only >> use roots_bitmap as a mutable reference but not takes roots_bitmap's >> ownership. > > Sorry but I cannot parse the last sentence above. I would have > expected that "Since/Because X" to be followed by comma and a > sentence that describes the consequence of X. Also "but not takes" > -> "but does not take", probably. You are right, I should use a grammar checker (chatgpt) on my log message. How about “ Since cascade_pseudo_merges_1() only use roots_bitmap as a mutable reference but not takes roots_bitmap's ownership. Once cascade_pseudo_merges_1() succeeds, roots_bitmap leaks. ” -> “ However, cascade_pseudo_merges_1() uses roots_bitmap as a mutable reference without taking ownership of it. As a result, if cascade_pseudo_merges_1() succeeds, roots_bitmap is leaked. ”
