On Thu, Jun 05, 2025 at 01:56:43PM +0100, Seyi Kuforiji wrote: > On Tue, 3 Jun 2025 at 14:51, Patrick Steinhardt <ps@xxxxxx> wrote: > > > > On Mon, Jun 02, 2025 at 01:25:58PM +0100, Seyi Kuforiji wrote: > > > diff --git a/Makefile b/Makefile > > > index 8ed8f234f4..8d8f2d574d 100644 > > > --- a/Makefile > > > +++ b/Makefile > > > @@ -1380,13 +1380,11 @@ CLAR_TEST_SUITES += u-urlmatch-normalization > > > CLAR_TEST_PROG = $(UNIT_TEST_BIN)/unit-tests$(X) > > > CLAR_TEST_OBJS = $(patsubst %,$(UNIT_TEST_DIR)/%.o,$(CLAR_TEST_SUITES)) > > > CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/clar/clar.o > > > -CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/unit-test.o > > > CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/lib-oid.o > > > -CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/lib-reftable-clar.o > > > +CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/lib-reftable.o > > > +CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/unit-test.o > > > > > > -UNIT_TEST_PROGS = $(patsubst %,$(UNIT_TEST_BIN)/%$X,$(UNIT_TEST_PROGRAMS)) > > > UNIT_TEST_OBJS += $(UNIT_TEST_DIR)/test-lib.o > > > > Can't "test-lib.c" also be deleted now? > > > > Patrick > > I don't think we can just yet, as `t/helper/test-example-tap` imports > the `test-lib.h.h` header file. Fixing that would be beyond the scope > of this patch series, don't you think? Yup, agreed. It may be useful to point out this detail in the commit message. Patrick
