2025年6月4日 15:48,Patrick Steinhardt <ps@xxxxxx> 写道: > > On Wed, Jun 04, 2025 at 03:08:56AM +0000, Lidong Yan via GitGitGadget wrote: >> From: Lidong Yan <502024330056@xxxxxxxxxxxxxxxx> >> >> In revision.c:prepare_show_merge(), we allocated an array in prune >> but forget to free it. Since parse_pathspec is not responsible to >> free prune, we should add `free(prune)` in the end of prepare_show_merge(). > > That is a rather obvious memory leak indeed. Do you know why we never > detected the leak in our CI? Is this code path not exercised at all by > our tests? > > Patrick > I don’t know why CI test doesn’t cover this leak, but I am happy to add a prereq test for this case. p.s. I also like to ask that it there anyway to run test locally? How do you developers normally run test without open an pull request. Thanks, Lidong