On Tue, Jun 03, 2025 at 03:07:36PM -0700, Junio C Hamano wrote:
> Mike Hommey <mh@xxxxxxxxxxxx> writes:
>
> > There is a similar problem with this code in refs/files-backend.c:
> >
> > if (!create_ref_symlink(lock, update->new_target))
> > continue;
> >
> > Where create_ref_symlink is defined as such:
> >
> > #ifdef NO_SYMLINK_HEAD
> > #define create_ref_symlink(a, b) (-1)
> > #else
> > static int create_ref_symlink(struct ref_lock *lock, const char *target)
> > {
> > ...
> > #endif
> >
> > And NO_SYMLINK_HEAD is defined on Windows.
>
> Would the NOT_CONSTANT() trick we ended up using for the original
> "sigfillset" thing solve your issue as well?
if (NOT_CONSTANT(!create_ref_symlink(lock, update->new_target)))
indeed works around it.
Mike
