Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> writes: > I noticed on Friday, while testing the v2.25.0-rc0 build, that test t6137 > failed on cygwin: > > $ tail test-out-2-50-rc0 > Test Summary Report > ------------------- > t6137-pathspec-wildcards-literal.sh (Wstat: 256 (exited 1) Tests: 25 Failed: 11) > Failed tests: 2, 7, 9, 11, 14-15, 17, 19, 21, 23, 25 > Non-zero exit status: 1 > Files=1023, Tests=30946, 21783 wallclock secs (19.08 usr 42.17 sys + 4031.65 cusr 12965.78 csys = 17058.68 CPU) > Result: FAIL > make[1]: *** [Makefile:78: prove] Error 1 > make[1]: Leaving directory '/home/ramsay/git/t' > make: *** [Makefile:3286: test] Error 2 > $ > > A quick squint at the failing tests made it clear that the failure was > caused by the cygwin build treating a quoted glob character sequence > (e.g. '\*') as a directory separator char followed by a glob character. Should we revert ec727e18 (dir.c: literal match with wildcard in pathspec should still glob, 2025-05-03) before deciding to how to proceed, as we will be deep in prerelease freeze? It's not a "fix" for something that is gravely wrong but a glitch people have lived with almost forever, so it can be reattempted in the next cycle without hurting much. Thanks.
