Re: [PATCH v4 00/10] meson: parse TAP output generated by our tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello

> Range-diff versus v3:
>
>  1:  0e9aac3c63f =  1:  05d16d9d7ac t: stop announcing prereqs
>  2:  2c3bd12eb5d !  2:  ed6a8b205f0 t: silence output from `test_create_repo()`
>     @@ t/t4041-diff-submodule-option.sh: test_expect_success 'typechanged submodule(sub
>      -test_create_repo sm1 &&
>      -head6=$(add_file sm1 foo6 foo7)
>      -fullhead6=$(cd sm1; git rev-parse --verify HEAD)
>     -+test_expect_success 'setup submodule' '
>     ++test_expect_success 'setup submodule anew' '
>      +	rm -f sm1 &&
>      +	git init sm1 &&
>      +	head6=$(add_file sm1 foo6 foo7) &&
>  3:  c659a0ce551 =  3:  cf05118aeae t9822: use prereq to check for ISO-8859-1 support
>  4:  e7141b15b56 !  4:  4d41989afe6 t983*: use prereq to check for Python-specific git-b4(1) support
>     @@ Metadata
>      Author: Patrick Steinhardt <ps@xxxxxx>
>
>       ## Commit message ##
>     -    t983*: use prereq to check for Python-specific git-b4(1) support
>     +    t983*: use prereq to check for Python-specific git-p4(1) support
>
>     -    The tests in t9835 and t9836 verify that git-b4(1) works with both
>     +    The tests in t9835 and t9836 verify that git-p4(1) works with both
>          Python 2 and 3, respectively. To determine whether we have those Python
>          versions in the first place we create a wrapper script that directly
>     -    executes the git-b4(1) script with `python2` or `python3` binaries. We
>     +    executes the git-p4(1) script with `python2` or `python3` binaries. We
>          then condition the execution of tests on whether that wrapper script can
>          be executed successfully.
>
>  5:  71b76db40e4 =  5:  b3f5f4e0d4d t/test-lib: don't print shell traces to stdout
>  6:  b60daf5ac69 !  6:  78ab5b1d331 t/test-lib: fix TAP format for BASH_XTRACEFD warning
>     @@ Commit message
>          t/test-lib: fix TAP format for BASH_XTRACEFD warning
>
>          When the Bash version is too old to support BASH_XTRACEFD we print a
>     -    warning to stderr. This warning breaks the TAP format because it is not
>     -    prefixed with a "#". Fix this.
>     +    warning to stderr. This warning is not prefixed with "#", which causes
>     +    TAP parsers to (wrongly) interpret the warning as part of the protocol.
>     +
>     +    Fix this issue by prefixing the warning with a "#" so that it is treated
>     +    as comment.
>
>          Signed-off-by: Patrick Steinhardt <ps@xxxxxx>
>
>  7:  ce55bee9a12 !  7:  61b8b7640b7 t7815: fix unexpectedly passing test on macOS
>     @@ Commit message
>
>          The test passes if '.' matches a NUL byte, which we expect to only
>          happen on Cygwin. The upcoming changes to support parsing TAP output in
>     -    Meson surface that this test is also unexpectedly passing on macOS
>     -    though.
>     +    Meson surface that this test, surprisingly, passes on macOS as well.
>
>          It is unclear how long the test has been passing on macOS already.
>          064eed36c7f (config.mak.uname: only set NO_REGEX on cygwin for v1.7,
>     -    2025-04-17) mentions that the test started to pass for Cygwin once it
>     -    has imported a newer implementation of regcomp(3p) et all, which was
>     +    2025-04-17) mentions that the test started to pass for Cygwin. This was
>     +    attributed to a new implementation of regcomp(3p) and friends, which was
>          inherited from FreeBSD. Given the BSD lineage of macOS it is feasible
>          that it also inherited similar code eventually that made the test pass
>          now.
>     @@ Commit message
>          same in this edge case and mark the new behaviour as expected.
>
>          This change is outside of the scope of this patch series, which only
>     -    introduce support for TAP. So instead of fixing the bigger issue, ignore
>     -    the test on Darwin like we already do for Cygwin.
>     +    introduces support for TAP. So instead of fixing the bigger issue,
>     +    ignore the test on Darwin like we already do for Cygwin.
>
>          Signed-off-by: Patrick Steinhardt <ps@xxxxxx>
>
>  8:  80dcf1d5979 =  8:  02011b7017c test-lib: fail on unexpectedly passing tests
>  9:  dca5730ab18 =  9:  540741acc80 meson: introduce kwargs variable for tests
> 10:  60393aa4af9 = 10:  8417d0ed94c meson: parse TAP output generated by our tests
>
> ---
> base-commit: 845c48a16a7f7b2c44d8cb137b16a4a1f0140229
> change-id: 20250429-pks-meson-tap-1eed604a02a3

The range-diff looks great. Thanks!

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux