Re: [PATCH v9 5/9] imap-send: enable specifying the folder using the command line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Aditya Garg <gargaditya08@xxxxxxxx> writes:

>> On 31 May 2025, at 6:15 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> 
>> Aditya Garg <gargaditya08@xxxxxxxx> writes:
>> 
>>> Some users may very often want to imap-send messages to a folder
>>> other than the default set in the config. Add a command line
>>> argument for the same.
>>> 
>>> Signed-off-by: Aditya Garg <gargaditya08@xxxxxxxx>
>>> ---
>>> Documentation/config/imap.adoc   |  5 +++--
>>> Documentation/git-imap-send.adoc | 15 +++++++++++----
>>> imap-send.c                      |  9 ++++++++-
>>> 3 files changed, 22 insertions(+), 7 deletions(-)
>> 
>> Did you forget to adjust tests that expect the traditional messages?
>
> I am not sure what you mean here. Could be more specific?
>
> In any case, whatever folder is passed using the --folder argument,
> will be treated the same way as the same folder would be when set
> using the config.

Ah, not this step, but if you ran

$ make test

you will see what I meant.  It failed during one of my integration
run.

Please make it a habit to always do so, if you haven't already,
before sending your patches.






[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux