"brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes:
> On 2025-05-29 at 16:17:14, Junio C Hamano wrote:
>> Corresponding definition we use in the main part of the project
>> defined in compat/posix.h looks like this:
>>
>> #if GIT_GNUC_PREREQ(4, 5)
>> #define UNUSED __attribute__((unused)) \
>> __attribute__((deprecated ("parameter declared as UNUSED")))
>> #elif defined(__GNUC__)
>> #define UNUSED __attribute__((unused)) \
>> __attribute__((deprecated))
>> #else
>> #define UNUSED
>> #endif
>>
>> GCC 4.5 or older may no longer be relevant, in which case yours may
>> be good enough.
>
> RHEL 7, which is now well past EOL, had GCC 4.8 and Debian 7, released
> in 2013 and also well past EOL, had GCC 4.7. I think we can safely
> assume nobody within our support policy is using GCC before 4.5.
Good digging. There is another one in git-compat-util.h that
is conditional on GIT_GNUC_PREREQ(3,1) which we can simplify away to
just "#ifdef __GNUC__", together with the above. Of course totally
outside of Carlo's fix to the reftable library.
Thanks.
