Re: [PATCH 1/2] userdiff: add support for R programming language

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > This singles out identifiers. Every single other characters would be its
> > own word. I'd consider this a disimprovement. If you are not prepared to
> > provide worddiff patterns, I recommend to use "[^ \t]+", which roughly
> > amounts to the default behavior. It can be improved incrementally in
> > later patches.
>
> Good point.

Thanks for the remark. I'll change to this approach in v2


> > Please squash the test cases into this patch. Don't forget to test an
> > indented function, and while at it, test a function definition *nested*
> > in a function definition: that documents what the expected outcome is.
>
> Again, good point.

Sure, that is an important feature that a userdiff driver should
address. Thanks again




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux