Lucas Seiki Oshiro <lucasseikioshiro@xxxxxxxxx> writes:
> Instruct in the documentation to also add an entry in meson.build for
> builtin/walken.c, as currently both Meson and Make are supported.
>
Nice.
> Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@xxxxxxxxx>
> ---
> Documentation/MyFirstObjectWalk.adoc | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/MyFirstObjectWalk.adoc b/Documentation/MyFirstObjectWalk.adoc
> index 29d26abb47..3b66e48dd9 100644
> --- a/Documentation/MyFirstObjectWalk.adoc
> +++ b/Documentation/MyFirstObjectWalk.adoc
> @@ -96,12 +96,19 @@ maintaining alphabetical ordering:
> { "walken", cmd_walken, RUN_SETUP },
> ----
>
> -Add it to the `Makefile` near the line for `builtin/worktree.o`:
> +Add an entry for the new command in the file of our two build systems (Make
> +and Meson) before the entry for `worktree`:
>
Super nit: The 'our two build systems' is a bit out of context, which is
why you also mention them in parenthesis. Perhaps we can simply name
them directly. Perhaps something like:
Add an entry for the new command in both the Make and Meson build
systems, before the entry for `worktree`:
Feel free to ignore this :)
> +- In the `Makefile`:
> ----
> BUILTIN_OBJS += builtin/walken.o
> ----
>
> +- In the `meson.build` file:
> +----
> + 'builtin/walken.c',
> +----
> +
> Build and test out your command, without forgetting to ensure the `DEVELOPER`
> flag is set, and with `GIT_TRACE` enabled so the debug output can be seen:
>
> --
> 2.39.5 (Apple Git-154)
Attachment:
signature.asc
Description: PGP signature
