On 29/05/25 9:31 pm, Junio C Hamano wrote:
> Aditya Garg <gargaditya08@xxxxxxxx> writes:
>
>> This patch fixes this by modifying the $header variable, which is
>> responsible for showing the logs at the end. Also, the log which states
>> that the Message-ID has been changed will now be shown only when
>> smtp-debug is enabled, since the main log having all of the headers is
>> anyways displaying the new Message-ID. It should look like this after
>> this patch:
>
> We do not say "This patch does X" or "I do Y" when describing a
> change. Rather, you give an order to somebody who is modifying the
> codebase to "make it so". Something like ...
>
> Fix this by updating the $header variable, which has the message
> ID we internally assigned on the "Message-ID:" header, with the
> message ID the Outlook server assigned.
Ok. Want me to send another revision, or we good for now?
>
> The change itself looks good, but ...
>
>> + # Replace the original Message-ID in $header with the new one
>> + $header =~ s/^(Message-ID:\s*).*\n/${1}$message_id\n/m;
>
> ... is the comment adding any useful information over what the code
> already says?
Considering the fact that making this regex what itself a pain, a small
comment for readers doesn't hurt right?
>
> Will queue, with a typofix to "incrmented" in [1/2].
>
> Thanks.
