On 2025-05-22 at 20:34:16, Junio C Hamano wrote: > "brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes: > > > + strbuf_init(&info->revision, 0); > > + if (parse_stash_revision(&info->revision, commit, 0)) { > > + return -1; > > } > > It does not look like this series add more code inside this block in > a later step, so let's lose the unnecessary {braces} around a single > statement "return -1" here. Sounds good. I'll fix that in a v7. > By the way, what is "pwodd" I saw in the e-mail header? A typo for "pwood", which is my alias for Phillip Wood, who I intended to CC. A typo which I unfortunately didn't catch before sending out patches (mostly because I was sitting in an airport lounge when I sent them out instead of using my giant screens at home). -- brian m. carlson (they/them) Toronto, Ontario, CA
Attachment:
signature.asc
Description: PGP signature