"brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes:
> On 2025-05-21 at 14:22:29, Aditya Garg wrote:
>> diff --git a/help.c b/help.c
>> index 6ef90838f1..238ed1913c 100644
>> --- a/help.c
>> +++ b/help.c
>> @@ -355,6 +355,9 @@ void list_common_cmds_help(void)
>> puts(_("These are common Git commands used in various situations:"));
>> putchar('\n');
>> print_cmd_by_category(common_categories, NULL);
>> +#ifdef _WIN32
>> + printf("\n'git update-git-for-windows' can be used to update git.\n");
>> +#endif
>
> I don't think this belongs in our codebase. It should instead be
> carried as a patch in Git for Windows. The reason is that there are a
> variety of possible projects that compile for Windows—Git for Windows,
> Cygwin, MINGW, etc.—and only one of them ships this binary. It is even
> possible for users to compile their own Windows binaries, which I know
> is at least done by Microsoft as well as some Git contributors on
> Windows.
>
> This change might be misleading or incorrect as it might tell users to
> invoke a binary which is not present or to update software in a way
> which is not via the normal package mechanism. For instance, telling a
> MINGW or Cygwin user to run that command would not result in anything
> useful or desired happening.
Do you mean that this is OK if the #ifdef were more specific to
Git-for-Windows? Just being curious.
