[Newcomer][PATCH] graph.c: change graph_line->width type to int to remove sign-compare warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



A comparison between graph_line->width (of type size_t) and git_graph->width (of type int) causes -Wsign-compare to complain.

Looking at the git_graph struct definition, its size variables are int-typed.

Therefore, I changed the type of graph_line->width to also be a int, thus removing the warning trigger.

Signed-off-by: Octavio Carneiro <ocarneiro1@xxxxxxxxx>
---
 graph.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/graph.c b/graph.c
index 26f6fbf000..cb2221700e 100644
--- a/graph.c
+++ b/graph.c
@@ -1,5 +1,3 @@
-#define DISABLE_SIGN_COMPARE_WARNINGS
-
 #include "git-compat-util.h"
 #include "gettext.h"
 #include "config.h"
@@ -115,7 +113,7 @@ static const char *column_get_color_code(unsigned short color)
 
 struct graph_line {
 	struct strbuf *buf;
-	size_t width;
+	int width;
 };
 
 static inline void graph_line_addch(struct graph_line *line, int c)
-- 
2.34.1





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux