Greetings,
At GitLab, we are interested in introducing an optional means to bypass
the connectivity checks performed through git-receive-pack(1). This
series implements a `--skip-connectivity-check` option to facilitate
this.
For some background, we have a transaction management system that runs
in our Git RPC service and wraps all repository operations. Operations
that write to a repository are first recorded and staged outside of the
repository. When committing a transaction, the connectivity of newly
written objects is checked by walking the object graph containing only
the new objects from the updated tips and identifying the missing
objects which represent the boundary between the new objects and the
repository. The boundary objects are then checked in the canonical
repository to ensure the new objects will connect as expected. All
repository operations are run in a transaction and conflict checked
before being applied serially to the canonical repository. This ensures
that operations that would break the repository are not applied.
For our specific use case, the conflict checks performed by
git-receive-pack(1) are redundant and thus we would like to introduce an
option that allows connectivity checks to be skipped.
Thanks for taking a look.
Changes since V1:
- Instead of creating a new test file, t5410 is generalized.
- Test assertions updated to more explicitly check for object
connectivity error messages.
- Updated commit message and added documentation for the option.
-Justin
Justin Tobler (2):
t5410: test receive-pack connectivity check
builtin/receive-pack: add option to skip connectivity check
Documentation/git-receive-pack.adoc | 12 ++++
builtin/receive-pack.c | 40 ++++++++------
t/meson.build | 2 +-
t/t5410-receive-pack-alternates.sh | 44 ---------------
t/t5410-receive-pack.sh | 86 +++++++++++++++++++++++++++++
5 files changed, 121 insertions(+), 63 deletions(-)
delete mode 100755 t/t5410-receive-pack-alternates.sh
create mode 100755 t/t5410-receive-pack.sh
base-commit: 6c0bd1fc70efaf053abe4e57c976afdc72d15377
--
2.49.0.111.g5b97a56fa0
