On Mon, May 19, 2025 at 02:44:22PM +0800, lidongyan wrote: > 2025年5月19日 14:02，Patrick Steinhardt <ps@xxxxxx> 写道： > > Okay. We _can_ do that now, but the patch doesn't explain why we > > _should_. > > The main purpose of this patch is to provide a test case to check whether > a memory leak occurs when loading a corrupt index file as requested here > https://lore.kernel.org/git/20250514180325.GB2196784@xxxxxxxxxxxxxxxxxxxxxxx. > A potential memory leak is mentioned in this patch here https://lore.kernel.org/git/pull.1962.git.git.1747052530271.gitgitgadget@xxxxxxxxx/. Wouldn't it make sense to include this in a v2 of that patch series then? That makes it way easier for the reviewer to draw the connection and allows you to draft commit messages in a way that they refer to one another. Patrick
