Karthik Nayak <karthik.188@xxxxxxxxx> writes: > Lucas Seiki Oshiro <lucasseikioshiro@xxxxxxxxx> writes: > >> Hello, again! >> >> In this v3 I did some minor adjustments based on the review of v2 >> (https://lore.kernel.org/git/20250512020935.73140-1-lucasseikioshiro@xxxxxxxxx/). >> > > This version looks good to me, thanks for the update. Yup, the result reads very well. Thanks, all. > I do have some general suggestions (not requirements): > - It would be nice if these patch versions were inlined with the > previous ones. Makes it easier to compare versions while reviewing. "git send-email --in-reply-to=..." is a good tool to use. > - Perhaps include a range-diff to make it easier to review the changes > in the new version compared to the last one. Here, "git format-patch --range-diff=..." can help when preparing the patches to be sent. > I can totally recommend b4 (https://b4.docs.kernel.org/en/latest/), it > helps manage both of the points I mentioned :) ... and more, by helping on the receiving end, too ;-).
