On Thu, May 15, 2025 at 01:11:46PM +0000, Johannes Schindelin via GitGitGadget wrote:
> CodeQL reports empty `if` blocks that only contain a comment as "futile
> conditional". The comment talks about potential plans to turn this into
> a warning, but that seems not to have been necessary. Replace the entire
> construct with a concise comment.
OK...
> - if (t->recursion_count) {
> - /*
> - * The current thread is exiting with
> - * timer[tid] still running.
> - *
> - * Technically, this is a bug, but I'm going
> - * to ignore it.
> - *
> - * I don't think it is worth calling die()
> - * for. I don't think it is worth killing the
> - * process for this bookkeeping error. We
> - * might want to call warning(), but I'm going
> - * to wait on that.
> - *
> - * The downside here is that total_ns won't
> - * include the current open interval (now -
> - * start_ns). I can live with that.
> - */
> - }
> + /*
> + * `t->recursion_count` could technically be non-zero, which
> + * would constitute a bug. Reporting the bug would potentially
> + * cause an infinite recursion, though, so let's ignore it.
> + */
The original doesn't talk about infinite recursion at all, though I can
well believe that would be the case, having run into trace->die->trace
types of bugs before. Did you trace out the actual path of recursion? If
so, it might be worth summarizing it.
Obviously the code change itself cannot hurt anything, as it was a noop.
-Peff
