> On 13 May 2025, at 1:45 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: > >> The problem is not restricted only to macOS (and Alpine), but more >> generally to all BSD-lineage `hostname` which does not understand >> --fqdn but does understand -f. > > True, but the proposed patch limits itself to > > $^O eq 'linux' || $^O eq 'darwin' > > for unfathomable reason, so BSD's are safe already ;-) Exactly. I had tested hostname -f on both macOS and Linux, but was lazy enough to not check --fqdn, thus resulting in a wrong patch. v3 and v4 should work properly. I'll also avoid laziness in the future.
