Re: [PATCH v3] REFTABLE_REALLOC_ARRAY: remove this unsafe yet unused macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Lidong Yan via GitGitGadget <gitgitgadget@xxxxxxxxx>
Subject: Re: [PATCH v3] REFTABLE_REALLOC_ARRAY: remove this unsafe yet unused macro
From: Patrick Steinhardt <ps@xxxxxx>
Date: Fri, 9 May 2025 10:23:47 +0200
Cc: git@xxxxxxxxxxxxxxx, René Scharfe <l.s.r@xxxxxx>, Lidong Yan <502024330056@xxxxxxxxxxxxxxxx>
Feedback-id: i197146af:Fastmail
In-reply-to: <pull.1955.v3.git.git.1746776686718.gitgitgadget@gmail.com>
References: <pull.1955.v2.git.git.1746756263207.gitgitgadget@gmail.com> <pull.1955.v3.git.git.1746776686718.gitgitgadget@gmail.com>

On Fri, May 09, 2025 at 07:44:46AM +0000, Lidong Yan via GitGitGadget wrote:
> From: Lidong Yan <502024330056@xxxxxxxxxxxxxxxx>
> 
> REFTABLE_REALLOC_ARRAY will cause memory leak if realloc failed.
> Since it is unused, remove this unsafe macro.

This looks good to me, thanks!

Patrick

Follow-Ups:
- Re: [PATCH v3] REFTABLE_REALLOC_ARRAY: remove this unsafe yet unused macro
  - From: Junio C Hamano

References:
- [PATCH v2] REFTABLE_REALLOC_ARRAY: remove this unsafe yet unused macro
  - From: Lidong Yan via GitGitGadget
- [PATCH v3] REFTABLE_REALLOC_ARRAY: remove this unsafe yet unused macro
  - From: Lidong Yan via GitGitGadget

Prev by Date: Re: [PATCH 10/10] contrib: remove "git-new-workdir"
Next by Date: Re: [PATCH v2] fill_oids_from_packs: fix memory leak when fill_oids_from_packs failed
Previous by thread: [PATCH v3] REFTABLE_REALLOC_ARRAY: remove this unsafe yet unused macro
Next by thread: Re: [PATCH v3] REFTABLE_REALLOC_ARRAY: remove this unsafe yet unused macro
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux