> Yuck, can we do something about this overly long mess?
>
> If use a temporary $subdomain = '(?!-)[A-Za-z0-9-]{1,63}(?<!-)',
> would it make it easier to spot the repetition in the structure,
> i.e. /^$subdomain(?:\.$subdomain)*$/ and make it less error prone
> when somebody has to touch lines around here, or something?
>
> But other than that, looking good.
>
> Even though this allows "foo.local", on "darwin" it is still not
> allowed, which sounds like a regression-free change
Sent a version 5 here: https://lore.kernel.org/git/PN3PR01MB95974932FF37D9F24A7633C6B88BA@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/T/#t
I forgot to add --in-reply-to while using git send-email to send v5, so it got sent
as a separate thread by mistake.
