Hi Li
On 07/05/2025 07:46, Li Chen wrote:
Some projects require every commit to carry a Reviewed-by: line
for accountability, much like the kernel requires Signed-off-by:.
A first‑class option keeps that workflow “out of the box”; otherwise
people need to define an alias such as
[alias]
rbr = rebase --trailer "Reviewed-by: $GIT_AUTHOR_NAME <$GIT_AUTHOR_EMAIL>"
which is functional but less convenient.
I would appreciate your further thoughts on whether a dedicated
flag(--reviewby) is acceptable, or whether we should drop it and rely solely on
the generic --trailer interface.
I think adding support for --trailer is a good idea and if we do that we
don't need --reviewby. The existence and implementation of --signoff is
largely a historical artifact - I'm not sure we'd make the same choices
if we were thinking about adding it today. Different projects have
different requirements and I don't think it is sensible to add a new
option catering to the different demands of each project.
I'll take a proper look at the second patch tomorrow.
Best Wishes
Phillip
Thanks again for the review.
Regards,
Li
