On Wed, May 07, 2025 at 02:33:22AM +0000, Lidong Yan via GitGitGadget wrote: > From: Lidong Yan <502024330056@xxxxxxxxxxxxxxxx> > > Signed-off-by: Lidong Yan <502024330056@xxxxxxxxxxxxxxxx> The same is true here -- this needs to have a proper commit subject and message. > diff --git a/parse-options.c b/parse-options.c > index 4279dfe4d313..12721b83000a 100644 > --- a/parse-options.c > +++ b/parse-options.c > @@ -638,7 +638,9 @@ static int has_subcommands(const struct option *options) > return 0; > } > > -static void set_strdup_fn(struct parse_opt_ctx_t *ctx, const struct option *options) { > +static void set_strdup_fn(struct parse_opt_ctx_t *ctx, > + const struct option *options) > +{ > for (; options->type != OPTION_END; options++) > ; > if (options->value && options->strdup_fn) { Please refrain from doing code style cleanups of code you have just introduced in the preceding commit. Patrick